leventov commented on a change in pull request #8235: Use Closer instead of
List<Closeable>
URL: https://github.com/apache/incubator-druid/pull/8235#discussion_r310684423
##########
File path: core/src/main/java/org/apache/druid/java/util/common/io/Closer.java
##########
@@ -123,6 +123,17 @@ private Closer()
return closeable;
}
+ /**
+ * Registers a list of {@code closeable} to be closed when this {@code
Closer} is
+ * {@linkplain #close closed}.
+ */
+ // close. this word no longer has any meaning to me.
+ public <C extends Closeable> Iterable<C> register(Iterable<C> closeables)
Review comment:
Some class may implement both `Iterable` and `Closeable`, so ambiguity with
the other `register()` method is possible. I suggest to call this method
`registerAll()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
