leventov commented on a change in pull request #8235: Use Closer instead of
List<Closeable>
URL: https://github.com/apache/incubator-druid/pull/8235#discussion_r310686115
##########
File path:
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/GroupByMergingQueryRunnerV2.java
##########
@@ -280,12 +280,17 @@ public AggregateResult call()
return RowBasedGrouperHelper.makeGrouperIterator(
grouper,
query,
- () -> Lists.reverse(resources).forEach(CloseQuietly::close)
+ resources
);
}
catch (Throwable e) {
// Exception caught while setting up the iterator; release
resources.
- Lists.reverse(resources).forEach(CloseQuietly::close);
+ try {
+ resources.close();
+ }
+ catch (IOException ex) {
Review comment:
I don't think it makes sense to catch anything weaker than `Throable` in
another `catch (Throwable e) {` block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
