leventov commented on a change in pull request #8209: add mechanism to control
filter optimization in historical query processing
URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310693015
##########
File path:
extensions-core/druid-bloom-filter/src/main/java/org/apache/druid/query/filter/BloomDimFilter.java
##########
@@ -193,16 +217,17 @@ public boolean equals(Object o)
if (o == null || getClass() != o.getClass()) {
return false;
}
-
BloomDimFilter that = (BloomDimFilter) o;
+ return dimension.equals(that.dimension) &&
+ hash.equals(that.hash) &&
+ Objects.equals(extractionFn, that.extractionFn) &&
Review comment:
Everything about `extractionFn`: the field, constructor parameter, getter
should be `@Nullable`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
