leventov commented on a change in pull request #8209: add mechanism to control
filter optimization in historical query processing
URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r311678810
##########
File path: processing/src/main/java/org/apache/druid/query/filter/Filter.java
##########
@@ -129,4 +130,19 @@ default boolean canVectorizeMatcher()
{
return false;
}
+
+ /**
+ * Set of columns used by a filter
+ */
+ Set<String> getRequiredColumns();
+
+ /**
+ * Determine if a filter *should* use a bitmap index based on information
collected from the supplied
+ * {@link BitmapIndexSelector}. This method differs from {@link
#supportsBitmapIndex(BitmapIndexSelector)} in that
+ * the former only indicates if a bitmap index is available and {@link
#getBitmapIndex(BitmapIndexSelector)} may be
+ * used. Implementations of this methods typically consider a {@link
FilterTuning} to make decisions about when to
Review comment:
Before the sentence "Implementations of this methods...", please add
```
*
* If shouldUseFilter(selector) returns true, {@link #supportsBitmapIndex}
must also return true when called with the
* same selector object.
*
```
as a separate paragraph.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
