clintropolis commented on a change in pull request #8209: add mechanism to
control filter optimization in historical query processing
URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310811872
##########
File path:
processing/src/main/java/org/apache/druid/query/filter/ColumnComparisonDimFilter.java
##########
@@ -114,10 +141,4 @@ public boolean equals(Object o)
.collect(Collectors.toSet())
Review comment:
I've changed the `DimFilter` interface to use `Set` instead of `HashSet` and
adjusted this to no longer dupe the set, along with changing single dimension
filters to use `ImmutableSet.of` instead of `Sets.newHashSet`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
