jihoonson commented on a change in pull request #8697: HRTR: make pending task execution handling to go through all tasks on not finding worker slots URL: https://github.com/apache/incubator-druid/pull/8697#discussion_r356339972
########## File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/hrtr/HttpRemoteTaskRunner.java ########## @@ -1501,6 +1623,23 @@ public void setState(State state) state ); + setStateUnconditionally(state); + } + + public void revertStateFromPendingWorkerAssignToPending() + { + Preconditions.checkState( + this.state == State.PENDING_WORKER_ASSIGN, + "Can't move state from [%s] to [%s]", + this.state, + State.PENDING + ); + + setStateUnconditionally(State.PENDING); + } + + private void setStateUnconditionally(State state) + { if (log.isDebugEnabled()) { log.debug( new RuntimeException("Stacktrace..."), Review comment: Is this to print the stack trace so that you can see where this method was called from when the log was printed? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org