jihoonson commented on a change in pull request #8697: HRTR: make pending task
execution handling to go through all tasks on not finding worker slots
URL: https://github.com/apache/incubator-druid/pull/8697#discussion_r356339621
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/overlord/hrtr/HttpRemoteTaskRunner.java
##########
@@ -1432,15 +1533,35 @@ void taskAddedOrUpdated(final TaskAnnouncement
announcement, final WorkerHolder
{
enum State
{
- PENDING(0),
- RUNNING(1),
- COMPLETE(2);
+ // Task has been given to HRTR, but a worker to run this task hasn't
been identified yet.
+ PENDING(0, true, RunnerTaskState.PENDING),
+
+ // A Worker has been identified to run this task, but request to run
task hasn't been made to worker yet
+ // or worker hasn't acknowledged the task yet.
+ PENDING_WORKER_ASSIGN(1, true, RunnerTaskState.PENDING),
- int index;
+ RUNNING(2, false, RunnerTaskState.RUNNING),
+ COMPLETE(3, false, RunnerTaskState.NONE);
- State(int index)
+ private int index;
+ private boolean isPending;
+ private RunnerTaskState runnerTaskState;
Review comment:
These variables can be final.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
