clintropolis commented on a change in pull request #9516: More efficient join
filter rewrites
URL: https://github.com/apache/druid/pull/9516#discussion_r393287117
##########
File path:
processing/src/main/java/org/apache/druid/segment/join/filter/JoinFilterAnalyzer.java
##########
@@ -311,124 +431,99 @@ private static JoinFilterAnalysis rewriteOrFilter(
);
}
- /**
- * Rewrites a selector filter on a join table into an IN filter on the base
table.
- *
- * @param baseColumnNames Set of names of columns that belong to the base
table, including pre-join virtual
- * columns
- * @param selectorFilter SelectorFilter to be rewritten
- * @param prefixes Map of join table prefixes to clauses
- * @param equiconditions Map of equiconditions
- * @param correlationCache Cache of column correlation analyses. This will
be potentially modified by adding
- * any new column correlation analyses to the cache.
- *
- * @return A JoinFilterAnalysis that indicates how to handle the potentially
rewritten filter
- */
private static JoinFilterAnalysis rewriteSelectorFilter(
Review comment:
same question about removal of javadocs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
