jon-wei commented on a change in pull request #9516: More efficient join filter rewrites URL: https://github.com/apache/druid/pull/9516#discussion_r393376174
########## File path: processing/src/test/java/org/apache/druid/segment/join/JoinFilterAnalyzerTest.java ########## @@ -245,6 +266,27 @@ public void test_filterPushDown_factToRegionToCountryLeftFilterOnNullColumns() ) ); + List<JoinableClause> joinableClauses = ImmutableList.of( + factToRegion(JoinType.LEFT), + regionToCountry(JoinType.LEFT) + ); + + JoinFilterPreAnalysis joinFilterPreAnalysis = JoinFilterAnalyzer.computeJoinFilterPreAnalysis( Review comment: Made a utility method ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org