jon-wei commented on a change in pull request #9516: More efficient join filter
rewrites
URL: https://github.com/apache/druid/pull/9516#discussion_r393376483
##########
File path:
processing/src/main/java/org/apache/druid/segment/join/filter/JoinFilterAnalyzer.java
##########
@@ -540,25 +607,15 @@ private static String
getCorrelatedBaseExprVirtualColumnName(int counter)
);
}
- List<JoinFilterColumnCorrelationAnalysis> dedupCorrelations =
eliminateCorrelationDuplicates(correlations);
-
- return Optional.of(dedupCorrelations);
+ if (correlations.size() == 0) {
+ return Optional.empty();
+ } else {
+ return Optional.of(correlations);
+ }
}
- /**
- * Helper method for {@link #findCorrelatedBaseTableColumns} that determines
correlated base table columns
- * and/or expressions for a single RHS column and adds them to the provided
sets as it traverses the
- * equicondition column relationships.
- *
- * @param baseColumnNames Set of names of columns that belong to the base
table, including pre-join virtual columns
- * @param equiConditions Map of equiconditions, keyed by the right hand
columns
- * @param rhsColumn RHS column to find base table correlations for
- * @param correlatedBaseColumns Set of correlated base column names for the
provided RHS column. Will be modified.
- * @param correlatedBaseExpressions Set of correlated base column
expressions for the provided RHS column. Will be
- * modified.
- */
private static void getCorrelationForRHSColumn(
- Set<String> baseColumnNames,
+ List<JoinableClause> joinableClauses,
Review comment:
Fixed, restored the docs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
