clintropolis commented on a change in pull request #10076:
URL: https://github.com/apache/druid/pull/10076#discussion_r445326768
##########
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##########
@@ -1036,11 +1047,13 @@ public boolean isReleasable()
@Override
public void close()
{
- try {
- yielder.close();
- }
- catch (IOException e) {
- throw new RuntimeException("Failed to close yielder", e);
+ if (yielder != null) {
+ try {
+ yielder.close();
+ }
+ catch (IOException e) {
+ throw new RuntimeException("Failed to close yielder", e);
Review comment:
I... can't remember if there is a reason why this explodes violently
while the others are all `CloseQuietly`... I'll try to figure out if this
should be eaten too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
