suneet-s commented on a change in pull request #10076:
URL: https://github.com/apache/druid/pull/10076#discussion_r446285774
##########
File path:
core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
##########
@@ -341,6 +344,7 @@ protected void compute()
}
}
catch (Exception ex) {
+ closeAllCursors(sequenceCursors);
Review comment:
Sorry, I misread this. A finally block won't work 🤦
Does it provide any better guarantees if we catch a Throwable instead of an
exception here - so that in case any of the code in the try block throws an
`Error` instead of an `Exception`
This code appears to have been running ok all this time with a `catch
(Exception)` block so I'm guessing it's not too bad if the catch condition is
left as is
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
