jihoonson commented on a change in pull request #10336:
URL: https://github.com/apache/druid/pull/10336#discussion_r482502260
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/StreamChunkParser.java
##########
@@ -54,12 +64,16 @@
@Nullable InputFormat inputFormat,
InputRowSchema inputRowSchema,
TransformSpec transformSpec,
- File indexingTmpDir
+ File indexingTmpDir,
+ Predicate<InputRow> rowFilter,
Review comment:
> I don't think we should use a Predicate<InputRow> here and in other
similar places. Throwing a ParseException is expected behavior, so I think
callers should know that they need to handle that exception or throw it
themselves.
>
> It's not obvious to me how the caller in
FilteringCloseableInputRowIterator should know they should handle a parse
exception
https://github.com/apache/druid/pull/10336/files#diff-b7f61f3d28afdd25bedf2efa607fdf88R67
Hmm, I'm not sure I understand your concern. Can you elaborate more?.
`rowFilter` is a simple predicate to filter out unnecessary rows and does
nothing with parseExceptions. Instead, it just passes the ParseException to the
caller if it is thrown in `test()`. The intention here is that the callers of
`FilteringCloseableInputRowIterator` can iterate rows without worrying about
validation of rows or parseExceptions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
