suneet-s commented on a change in pull request #10336:
URL: https://github.com/apache/druid/pull/10336#discussion_r483375527
##########
File path:
server/src/main/java/org/apache/druid/segment/realtime/appenderator/AppenderatorImpl.java
##########
@@ -267,6 +275,12 @@ public AppenderatorAddResult add(
throw new SegmentNotWritableException("Attempt to add row to swapped-out
sink for segment[%s].", identifier);
}
+ if (addResult.isRowAdded()) {
+ rowIngestionMeters.incrementProcessed();
+ } else if (addResult.hasParseException()) {
+ parseExceptionHandler.handle(addResult.getParseException());
+ }
Review comment:
Test coverage bot is complaining about a lack of coverage for this
condition. I think we should add tests for these branches. Right now
`AppenderatorTest` only tests `addResult.isRowAdded`
Covering all 4 branches should make the code coverage bot happy too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
