zhangyue19921010 commented on a change in pull request #10551:
URL: https://github.com/apache/druid/pull/10551#discussion_r519603362
##########
File path:
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaConsumerConfigs.java
##########
@@ -38,7 +38,6 @@
props.put("group.id", StringUtils.format("kafka-supervisor-%s",
IdUtils.getRandomId()));
props.put("auto.offset.reset", "none");
props.put("enable.auto.commit", "false");
- props.put("isolation.level", "read_committed");
Review comment:
Make sense! I add a new property named `consumeTransactionally` in
consumerProperties, which is a Kafka consumer level property to control
`isolation.level`;
If users don't set `consumeTransactionally` or set `consumeTransactionally`
true, druid will consume Kafka Transactionally by default.
Set `consumeTransactionally` false here can disable druid to consume Kafka
Transactionally, which means druid can consume lower version of Kafka now like
0.10.x
In this way, we don't change current Druid default behavior and provide a
way to let druid consume lower version Kafka.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
