zhangyue19921010 commented on a change in pull request #10551: URL: https://github.com/apache/druid/pull/10551#discussion_r521861277
########## File path: extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaConsumerConfigs.java ########## @@ -30,15 +30,23 @@ */ public class KafkaConsumerConfigs { - - public static Map<String, Object> getConsumerProperties() + public static Map<String, Object> getConsumerProperties(Map<String, Object> customerConsumerProperties) { + final Object value = customerConsumerProperties.remove("consumeTransactionally"); Review comment: Hi FrankChen021, I have put the new property `consumeTransactionally` in the `KafkaSupervisorIOConfig` directly. If users ignore this config or set this config true, Druid would consume Kafka transactionally same as current Druid behavior. Set consumeTransactionally false here can disable Druid to consume Kafka transactionally, meanwhile Druid could consume lower version of Kafka now like 0.10.2.1 . In this way, we don't change current Druid default behavior and provide a way to let Druid consume lower version Kafka. I have tested this PR in our Dev Druid cluster. Please take a look. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org