maytasm commented on a change in pull request #11025:
URL: https://github.com/apache/druid/pull/11025#discussion_r605184280



##########
File path: 
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java
##########
@@ -108,7 +110,7 @@ public IndexerSQLMetadataStorageCoordinator(
     this.connector = connector;
   }
 
-  enum DataSourceMetadataUpdateResult
+  enum DataStoreMetadataUpdateResult

Review comment:
       Previously, in IndexerSQLMetadataStorageCoordinator we only update the 
datasource table, hence the result enum is named 
DataSourceMetadataUpdateResult. However, now the 
IndexerSQLMetadataStorageCoordinator have methods to update both the datasource 
table and the segment table in metadata store. Instead of having two enum which 
are pretty much the same, I just rename this enum so that it can be use for 
handling the result of updating any/both tables in metadata store...no matter 
which tables. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to