maytasm commented on a change in pull request #11025:
URL: https://github.com/apache/druid/pull/11025#discussion_r605355879
##########
File path: docs/ingestion/compaction.md
##########
@@ -52,7 +52,7 @@ In cases where you require more control over compaction, you
can manually submit
See [Setting up a manual compaction task](#setting-up-manual-compaction) for
more about manual compaction tasks.
## Data handling with compaction
-During compaction, Druid overwrites the original set of segments with the
compacted set. During compaction Druid locks the segments for the time interval
being compacted to ensure data consistency. By default, compaction tasks do not
modify the underlying data. You can configure the compaction task to change the
query granularity or add or remove dimensions in the compaction task. This
means that the only changes to query results should be the result of
intentional, not automatic, changes.
+During compaction, Druid overwrites the original set of segments with the
compacted set. During compaction Druid locks the segments for the time interval
being compacted to ensure data consistency. By default, compaction tasks do not
modify the underlying data. You can configure the compaction task to change the
query granularity or add or remove dimensions in the compaction task. This
means that the only changes to query results should be the result of
intentional, not automatic, changes. Note that compaction task automatically
set `dropExisting` flag of the underlying ingestion task to true. This means
that compaction task would drop (mark unused) all existing segments that are
fully contain by the `interval` in the compaction task. This is to handle when
compaction task changes segmentGranularity of the existing data to a finer
segmentGranularity and the set of new segments (with the new
segmentGranularity) does not fully cover the original croaser granularity time
interval (as t
here may not be data in every time chunk of the new finer segmentGranularity).
Review comment:
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
