FrankChen021 commented on code in PR #12763: URL: https://github.com/apache/druid/pull/12763#discussion_r917223575
########## processing/src/main/java/org/apache/druid/query/groupby/GroupByQueryConfig.java: ########## @@ -75,11 +82,11 @@ @JsonProperty // Size of on-heap string dictionary for merging, per-processing-thread; when exceeded, partial results will be // emitted to the merge buffer early. - private long maxSelectorDictionarySize = 100_000_000L; + private long maxSelectorDictionarySize = AUTOMATIC; @JsonProperty // Size of on-heap string dictionary for merging, per-query; when exceeded, partial results will be spilled to disk - private long maxMergingDictionarySize = 100_000_000L; + private long maxMergingDictionarySize = AUTOMATIC; Review Comment: I think we can change the type of `maxSelectorDictionarySize` and `maxMergingDictionarySize` from `long` to `HumanReadableBytes` to support human-readable format configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
