FrankChen021 commented on code in PR #12763:
URL: https://github.com/apache/druid/pull/12763#discussion_r917223643
##########
processing/src/main/java/org/apache/druid/query/groupby/GroupByQueryConfig.java:
##########
@@ -259,20 +310,8 @@ public GroupByQueryConfig withOverrides(final GroupByQuery
query)
((Number) query.getContextValue(CTX_KEY_MAX_ON_DISK_STORAGE,
getMaxOnDiskStorage())).longValue(),
getMaxOnDiskStorage()
);
- newConfig.maxSelectorDictionarySize = Math.min(
- ((Number) query.getContextValue(
- CTX_KEY_MAX_SELECTOR_DICTIONARY_SIZE,
- getMaxSelectorDictionarySize()
- )).longValue(),
- getMaxSelectorDictionarySize()
- );
- newConfig.maxMergingDictionarySize = Math.min(
- ((Number) query.getContextValue(
- CTX_KEY_MAX_MERGING_DICTIONARY_SIZE,
- getMaxMergingDictionarySize()
- )).longValue(),
- getMaxMergingDictionarySize()
- );
Review Comment:
Since these two are removed from QueryContext, should we document it in the
release notes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
