rohangarg commented on code in PR #13269: URL: https://github.com/apache/druid/pull/13269#discussion_r1016389633
########## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/guice/MSQDurableStorageModule.java: ########## @@ -47,6 +51,7 @@ public class MSQDurableStorageModule implements DruidModule @Inject private Properties properties; + // Dummy constructor so that it can get injected dynamically at runtime Review Comment: does moving `@Inject` from member variable `properties` to `MSQDurableStorageModule(Properties properties)` constructor also work, which could make the default constructor obsolete? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
