adarshsanjeev commented on code in PR #13269:
URL: https://github.com/apache/druid/pull/13269#discussion_r1017502240
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/DurableStorageCleanerConfig.java:
##########
@@ -19,59 +19,31 @@
package org.apache.druid.msq.indexing;
-import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
-import com.google.common.base.Preconditions;
+
+import javax.validation.constraints.Min;
public class DurableStorageCleanerConfig
{
- private static final long DEFAULT_INITIAL_DELAY_SECONDS = 86400L;
- private static final long DEFAULT_DELAY_SECONDS = 86400L;
-
/**
* Whether the {@link DurableStorageCleaner} helper should be enabled or not
*/
@JsonProperty
- private final boolean enabled;
-
- /**
- * Initial delay in seconds post which the durable storage cleaner should run
- */
- @JsonProperty
- private final long initialDelaySeconds;
+ public boolean enabled = false;
Review Comment:
The config properties could be private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
