clintropolis commented on code in PR #14124:
URL: https://github.com/apache/druid/pull/14124#discussion_r1243099086
##########
sql/src/main/java/org/apache/druid/sql/calcite/expression/OperatorConversions.java:
##########
@@ -303,7 +303,7 @@ public static PostAggregator toPostAggregator(
postAggregatorVisitor.getOutputNamePrefix() +
postAggregatorVisitor.getAndIncrementCounter(),
druidExpression.getExpression(),
null,
- plannerContext.getExprMacroTable()
+ plannerContext.parse(druidExpression.getExpression())
Review Comment:
nit: am conflicted, this reads funny like it isn't obvious at a glance it is
parsing native expressions since like why would that be built-in to the
plannerContext, otoh it would be hella tedious to always be
`plannerContext.getExpressionParser().parse(...)` all the time..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
