gianm commented on code in PR #14124:
URL: https://github.com/apache/druid/pull/14124#discussion_r1244047939
##########
sql/src/main/java/org/apache/druid/sql/calcite/expression/OperatorConversions.java:
##########
@@ -303,7 +303,7 @@ public static PostAggregator toPostAggregator(
postAggregatorVisitor.getOutputNamePrefix() +
postAggregatorVisitor.getAndIncrementCounter(),
druidExpression.getExpression(),
null,
- plannerContext.getExprMacroTable()
+ plannerContext.parse(druidExpression.getExpression())
Review Comment:
Yeah, the idea is to avoid doing
`plannerContext.getExpressionParser().parse(...)` all the time.
What do you think about naming it `plannerContext.parseExpression(...)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
