gianm commented on PR #14490: URL: https://github.com/apache/druid/pull/14490#issuecomment-1611683929
This change would make the "explain clustered by" feature work in more cases, but it definitely still won't work in all cases, and IMO we don't want to make the entire `EXPLAIN` statement blow up if we can't figure out the clustered by columns. So, I think we should go in one of two directions for this work: 1. Figure out a way to make the "explain clustered by" feature _always_ work, which might potentially involve moving this logic somewhere else, or refactoring something. 2. Embrace that it might not always work, and have that not fail the `EXPLAIN`, but instead return some kind of signifier in the response that we can't figure out the clustered-by columns. Callers would need to look at that to be able to differentiate "no clustered by" from "can't figure out clustered by". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
