abhishekrb19 commented on PR #14490: URL: https://github.com/apache/druid/pull/14490#issuecomment-1614869280
@gianm, thanks for the review. Yes, I went ahead with 1 -- moving this logic to _after_ the query is _prepared_ enables us to extract the necessary output columns from `rootQueryRel` always - instead of relying on the different `SqlNode` types in the pre-prepare phase. Another benefit of doing it after the query preparation phase is that it already goes through the validation checks. IMO, the code looks simpler. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
