LakshSingla commented on code in PR #14527:
URL: https://github.com/apache/druid/pull/14527#discussion_r1254346128
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQControllerTask.java:
##########
@@ -263,4 +265,9 @@ public static boolean isIngestion(final MSQSpec querySpec)
{
return querySpec.getDestination() instanceof DataSourceMSQDestination;
}
+
+ public static boolean writeResultsToDurableStorage(final MSQSpec querySpec)
Review Comment:
nit: Naming. From the name, the method seems like it writes the results to
durable storage and returns whether the write was successful.
```suggestion
public static boolean isWriteResultsToDurableStorage(final MSQSpec
querySpec)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
