cryptoe commented on code in PR #14527:
URL: https://github.com/apache/druid/pull/14527#discussion_r1254606581
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/MSQTasks.java:
##########
@@ -155,7 +156,11 @@ static String getHostFromSelfNode(@Nullable final
DruidNode selfNode)
static StorageConnector makeStorageConnector(final Injector injector)
{
try {
- return injector.getInstance(Key.get(StorageConnector.class,
MultiStageQuery.class));
+ StorageConnector storageConnector =
injector.getInstance(Key.get(StorageConnector.class, MultiStageQuery.class));
+ if (storageConnector instanceof NilStorageConnector) {
+ throw new Exception("Storage connector not configured.");
Review Comment:
That is also one approach. Since we would need to check this in the broker
as well, I thought we can make it similar in all places.
I think what I can do is keep doing this check but also bind the
NilStorageConnector only to the broker role.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
