somu-imply commented on code in PR #14655: URL: https://github.com/apache/druid/pull/14655#discussion_r1273706012
########## processing/src/main/java/org/apache/druid/query/aggregation/last/StringLastVectorAggregator.java: ########## @@ -42,7 +42,7 @@ public class StringLastVectorAggregator implements VectorAggregator protected long lastTime; public StringLastVectorAggregator( - final BaseLongVectorValueSelector timeSelector, + @Nullable final BaseLongVectorValueSelector timeSelector, Review Comment: Should make the time selector nullable for NumericLastVector aggregator too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
