abhishekagarwal87 commented on code in PR #14655:
URL: https://github.com/apache/druid/pull/14655#discussion_r1274342141
##########
processing/src/main/java/org/apache/druid/query/aggregation/last/StringLastVectorAggregator.java:
##########
@@ -42,7 +42,7 @@ public class StringLastVectorAggregator implements
VectorAggregator
protected long lastTime;
public StringLastVectorAggregator(
- final BaseLongVectorValueSelector timeSelector,
+ @Nullable final BaseLongVectorValueSelector timeSelector,
Review Comment:
those aggregators are never created with null timeSelector.
```
BaseLongVectorValueSelector timeSelector = (BaseLongVectorValueSelector)
columnSelectorFactory.makeValueSelector(
timeColumn);
if (capabilities == null || capabilities.isNumeric()) {
return new DoubleLastVectorAggregator(timeSelector, valueSelector);
} else {
return NumericNilVectorAggregator.doubleNilVectorAggregator();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
