kfaraz commented on code in PR #14935:
URL: https://github.com/apache/druid/pull/14935#discussion_r1312542737
##########
docs/development/extensions-contrib/prometheus.md:
##########
@@ -47,6 +47,7 @@ All the configuration parameters for the Prometheus emitter
are under `druid.emi
| `druid.emitter.prometheus.pushGatewayAddress` | Pushgateway address.
Required if using `pushgateway` strategy.
| no | none
|
| `druid.emitter.prometheus.flushPeriod` | Emit metrics to Pushgateway
every `flushPeriod` seconds. Required if `pushgateway` strategy is used.
| no | 15
|
| `druid.emitter.prometheus.extraLabels` | JSON key-value pairs for
additional labels on all metrics. Keys (label names) must match the regex
`[a-zA-Z_:][a-zA-Z0-9_:]*`. Example: `{"cluster_name": "druid_cluster1", "env":
"staging"}`. | no | none
|
+| `druid.emitter.prometheus.deleteOnShutdown` | Flag to delete metrics from
Pushgateway on shutdown. Works only if `pushgateway` strategy is used.
| no | false
|
Review Comment:
Since this config is specific to `pushgateway` strategy, do you think we
should rename it to `pushGatewayDeleteOnShutdown` instead?
##########
extensions-contrib/prometheus-emitter/src/main/java/org/apache/druid/emitter/prometheus/PrometheusEmitterConfig.java:
##########
@@ -80,7 +83,8 @@ public PrometheusEmitterConfig(
@JsonProperty("addHostAsLabel") boolean addHostAsLabel,
@JsonProperty("addServiceAsLabel") boolean addServiceAsLabel,
@JsonProperty("flushPeriod") Integer flushPeriod,
- @JsonProperty("extraLabels") @Nullable Map<String, String> extraLabels
+ @JsonProperty("extraLabels") @Nullable Map<String, String> extraLabels,
+ @JsonProperty("deleteOnShutdown") boolean deleteOnShutdown
Review Comment:
The documentation says that this field is not required. In that case, it
should be marked `@Nullable` and use a boxed `Boolean` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
