BartMiki commented on code in PR #14935:
URL: https://github.com/apache/druid/pull/14935#discussion_r1335568176
##########
extensions-contrib/prometheus-emitter/src/main/java/org/apache/druid/emitter/prometheus/PrometheusEmitter.java:
##########
@@ -207,6 +207,15 @@ public void close()
} else {
exec.shutdownNow();
flush();
+
+ if (pushGateway != null && config.isDeleteOnShutdown()) {
+ try {
+ pushGateway.delete(config.getNamespace(),
ImmutableMap.of(config.getNamespace(), identifier));
Review Comment:
Hi @abhishekrb19 and @kfaraz! Should I proceed with the proposed change?
What is your opinion? Also regarding the build errors, the build passes on my
machine perhaps the test rerun would help (I have had a similar issue with
other PR too and the rerun has helped).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
