clintropolis commented on code in PR #14956:
URL: https://github.com/apache/druid/pull/14956#discussion_r1323471660
##########
sql/src/main/java/org/apache/druid/sql/calcite/expression/builtin/QueryLookupOperatorConversion.java:
##########
@@ -91,4 +103,18 @@ public DruidExpression toDruidExpression(
}
);
}
+
+ private String getReplaceMissingValueWith(
+ final List<DruidExpression> inputExpressions,
+ final PlannerContext plannerContext
+ )
+ {
+ if (inputExpressions.size() > 2) {
+ final Expr missingValExpr =
plannerContext.parseExpression(inputExpressions.get(2).getExpression());
+ if (missingValExpr.isLiteral()) {
+ return missingValExpr.getLiteralValue().toString();
Review Comment:
can this argument be null? (add a test with the argument as NULL if it
parses correctly, ignore if not)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
