pranavbhole commented on code in PR #14956:
URL: https://github.com/apache/druid/pull/14956#discussion_r1342076645
##########
sql/src/main/java/org/apache/druid/sql/calcite/expression/builtin/QueryLookupOperatorConversion.java:
##########
@@ -91,4 +103,18 @@ public DruidExpression toDruidExpression(
}
);
}
+
+ private String getReplaceMissingValueWith(
+ final List<DruidExpression> inputExpressions,
+ final PlannerContext plannerContext
+ )
+ {
+ if (inputExpressions.size() > 2) {
+ final Expr missingValExpr =
plannerContext.parseExpression(inputExpressions.get(2).getExpression());
+ if (missingValExpr.isLiteral()) {
+ return missingValExpr.getLiteralValue().toString();
Review Comment:
yes it can be null, newly added test validates the correct behavior.
Thank you
##########
sql/src/main/java/org/apache/druid/sql/calcite/expression/builtin/QueryLookupOperatorConversion.java:
##########
@@ -30,16 +30,27 @@
import org.apache.druid.query.lookup.LookupExtractorFactoryContainerProvider;
import org.apache.druid.query.lookup.RegisteredLookupExtractionFn;
import org.apache.druid.segment.column.RowSignature;
+import org.apache.druid.sql.calcite.expression.BasicOperandTypeChecker;
import org.apache.druid.sql.calcite.expression.DruidExpression;
import org.apache.druid.sql.calcite.expression.OperatorConversions;
import org.apache.druid.sql.calcite.expression.SqlOperatorConversion;
import org.apache.druid.sql.calcite.planner.PlannerContext;
+import java.util.List;
+
public class QueryLookupOperatorConversion implements SqlOperatorConversion
{
private static final SqlFunction SQL_FUNCTION = OperatorConversions
.operatorBuilder("LOOKUP")
- .operandTypes(SqlTypeFamily.CHARACTER, SqlTypeFamily.CHARACTER)
+ .operandTypeChecker(
+ BasicOperandTypeChecker.builder()
+ .operandTypes(
+ SqlTypeFamily.CHARACTER,
+ SqlTypeFamily.CHARACTER,
+ SqlTypeFamily.CHARACTER
+ )
+ .requiredOperandCount(2)
Review Comment:
fixed
##########
docs/querying/sql-scalar.md:
##########
@@ -98,7 +98,7 @@ String functions accept strings, and return a type
appropriate to the function.
|`CHAR_LENGTH(expr)`|Alias for `LENGTH`.|
|`CHARACTER_LENGTH(expr)`|Alias for `LENGTH`.|
|`STRLEN(expr)`|Alias for `LENGTH`.|
-|`LOOKUP(expr, lookupName)`|Look up `expr` in a registered [query-time lookup
table](lookups.md). Note that lookups can also be queried directly using the
[`lookup` schema](sql.md#from).|
+|`LOOKUP(expr, lookupName, [replaceMissingValueWith])`|Look up `expr` in a
registered [query-time lookup table](lookups.md). Note that lookups can also be
queried directly using the [`lookup` schema](sql.md#from).|
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
