somu-imply commented on code in PR #14975: URL: https://github.com/apache/druid/pull/14975#discussion_r1324943043
########## server/src/test/java/org/apache/druid/server/QueryResultPusherTest.java: ########## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.server; + +import com.fasterxml.jackson.databind.ObjectMapper; +import com.google.common.base.Throwables; +import org.apache.druid.server.QueryResultPusher.ResultsWriter; +import org.junit.Test; + +import javax.servlet.http.HttpServletRequest; +import javax.ws.rs.core.MediaType; + +import java.io.IOException; +import java.io.OutputStream; +import java.util.HashMap; +import java.util.Map; + +import static org.mockito.ArgumentMatchers.argThat; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.verify; +import static org.mockito.Mockito.when; + +public class QueryResultPusherTest +{ + @Test + public void testResultPusherRetainsNestedExceptionBacktraces() + { + HttpServletRequest request = mock(HttpServletRequest.class); + ObjectMapper jsonMapper = new ObjectMapper(); + ResponseContextConfig responseContextConfig = ResponseContextConfig.newConfig(true); + DruidNode selfNode = mock(DruidNode.class); + QueryResource.QueryMetricCounter counter = mock(QueryResource.QueryMetricCounter.class); + String queryId = "someQuery"; + MediaType contentType = null; + Map<String, String> extraHeaders = new HashMap<String, String>(); + + ResultsWriter resultWriter = mock(ResultsWriter.class); + + QueryResultPusher pusher = new QueryResultPusher( + request, + jsonMapper, + responseContextConfig, + selfNode, + counter, + queryId, + contentType, + extraHeaders) + { + + @Override + public void writeException(Exception e, OutputStream out) throws IOException + { + throw new RuntimeException("Unimplemented!"); Review Comment: maybe just do a ` out.write() ` here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
