kgyrtkirk commented on code in PR #14975:
URL: https://github.com/apache/druid/pull/14975#discussion_r1325574378


##########
server/src/main/java/org/apache/druid/server/QueryResultPusher.java:
##########
@@ -278,6 +274,17 @@ private Response handleDruidException(ResultsWriter 
resultsWriter, DruidExceptio
     }
   }
 
+  private DruidException toDruidException(Exception e)
+  {
+    if (e instanceof DruidException) {
+      return (DruidException) e;
+    }
+    if (!(e instanceof QueryException)) {
+      e = new QueryInterruptedException(e);
+    }
+    return DruidException.fromFailure(new 
QueryExceptionCompat((QueryException) e));

Review Comment:
   yes - actually; I've changed the way this is fixed
   
   I now think that it was not intentional that `QueryExceptionCompat` have not 
passed the `exception`  ; only it's message
   
   cc: @cheddar 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to