xvrl commented on code in PR #15014:
URL: https://github.com/apache/druid/pull/15014#discussion_r1332018344
##########
processing/src/test/java/org/apache/druid/query/aggregation/constant/LongConstantBufferAggregatorTest.java:
##########
@@ -38,9 +37,7 @@ public void setup()
{
randomVal = RandomUtils.nextLong();
aggregator = new LongConstantBufferAggregator(randomVal);
- byteBuffer = EasyMock.mock(ByteBuffer.class);
- EasyMock.replay(byteBuffer);
- EasyMock.verifyUnexpectedCalls(byteBuffer);
+ byteBuffer = ByteBuffer.allocate(Long.BYTES);
Review Comment:
right, that may have been the intent, but it wasn't actually testing for
anything, since it would call verify before actually running the test. I can
make it null to ensure we test it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
