xvrl commented on code in PR #15014:
URL: https://github.com/apache/druid/pull/15014#discussion_r1332020678
##########
sql/src/test/java/org/apache/druid/sql/calcite/rule/DruidLogicalValuesRuleTest.java:
##########
@@ -101,7 +102,7 @@ private static RexLiteral makeLiteral(Comparable<?> val,
SqlTypeName typeName, C
Mockito.when(dataType.getSqlTypeName()).thenReturn(typeName);
RexLiteral literal = Mockito.mock(RexLiteral.class);
try {
- Field field =
literal.getClass().getSuperclass().getDeclaredField("value");
Review Comment:
that would be better, I suspect this change is required due to changes in
how mocks are implemented in mockito 5.x. If we need to run tests with both 5.x
and 4.x for Java 8 + Java 21 your approach is much more maintainable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
