LakshSingla commented on code in PR #14900:
URL: https://github.com/apache/druid/pull/14900#discussion_r1344124503
##########
processing/src/main/java/org/apache/druid/frame/read/FrameReader.java:
##########
@@ -96,11 +115,28 @@ public static FrameReader create(final RowSignature
signature)
signature.getColumnName(columnNumber)
);
- columnReaders.add(FrameColumnReaders.create(columnNumber, columnType));
fieldReaders.add(FieldReaders.create(signature.getColumnName(columnNumber),
columnType));
+
+ // If we encounter a numeric array type, then don't throw the error
immediately since the reader can be used to
+ // read only the ROW_BASED frames. Rather, set the optional, and throw
the appropriate error message when the reader
+ // tries to read COLUMNAR frame. This should go away once the COLUMNAR
frames also start supporting the numeric
+ // array
+ if (columnType.getType() == ValueType.ARRAY
Review Comment:
Will remove the conditional altogether, and add a dummy column reader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
