LakshSingla commented on code in PR #14900: URL: https://github.com/apache/druid/pull/14900#discussion_r1344752145
########## processing/src/main/java/org/apache/druid/frame/field/NumericFieldReader.java: ########## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.frame.field; + +import org.apache.datasketches.memory.Memory; +import org.apache.druid.query.extraction.ExtractionFn; +import org.apache.druid.segment.ColumnValueSelector; +import org.apache.druid.segment.DimensionSelector; +import org.apache.druid.segment.column.ValueType; +import org.apache.druid.segment.column.ValueTypes; + +import javax.annotation.Nullable; + +/** + * Reads the fields created by the {@link NumericFieldWriter}. See the Javadoc for the writer for format details + */ +public abstract class NumericFieldReader implements FieldReader +{ + + /** + * The indicator byte which denotes that the following value is null. + */ + private final byte nullIndicatorByte; + + public NumericFieldReader(boolean forArray) + { + if (!forArray) { + this.nullIndicatorByte = NumericFieldWriter.NULL_BYTE; + } else { + this.nullIndicatorByte = NumericFieldWriter.ARRAY_ELEMENT_NULL_BYTE; + } + } + + @Override + public ColumnValueSelector<?> makeColumnValueSelector(Memory memory, ReadableFieldPointer fieldPointer) + { + return getColumnValueSelector(memory, fieldPointer, nullIndicatorByte); + } + + @Override + public DimensionSelector makeDimensionSelector( + Memory memory, + ReadableFieldPointer fieldPointer, + @Nullable ExtractionFn extractionFn + ) + { + return ValueTypes.makeNumericWrappingDimensionSelector( + getValueType(), + makeColumnValueSelector(memory, fieldPointer), + extractionFn + ); + } + + @Override + public boolean isNull(Memory memory, long position) + { + return memory.getByte(position) == nullIndicatorByte; + } + + + @Override + public boolean isComparable() + { + return true; + } + + public abstract ColumnValueSelector<?> getColumnValueSelector( + Memory memory, + ReadableFieldPointer fieldPointer, + byte nullIndicatorByte + ); + + public abstract ValueType getValueType(); + + public abstract static class Selector Review Comment: All of the previous implementations of the field readers kept the selector as a private class inside their code, therefore I kept the selectors inside the parent class. Since this one is getting inherited, I'll move this out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
