clintropolis opened a new pull request, #15192: URL: https://github.com/apache/druid/pull/15192
### Description Fixes an issue from #15058 with value matchers created by `UnnestDimensionCursor` for matches against non-existent values, which I forgot to update to match only null rows whenever `includeUnknown` is set to true. I checked around and didn't notice any other implementations with this issue, the problem was that it was treating the case as a non-existent column instead of an always false matcher that should only match null rows when `includeUnknown` is true, and so instead would effectively match nothing when used with a not filter. Added tests cover the case. This PR has: - [x] been self-reviewed. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
