soumyava commented on code in PR #15192:
URL: https://github.com/apache/druid/pull/15192#discussion_r1363058075
##########
processing/src/test/java/org/apache/druid/query/groupby/UnnestGroupByQueryRunnerTest.java:
##########
@@ -704,6 +706,229 @@ private Iterable<ResultRow> runQuery(final GroupByQuery
query, final Incremental
return GroupByQueryRunnerTestHelper.runQuery(factory, queryRunner, query);
}
+ @Test
+ public void testGroupByOnUnnestedFilterMatch()
+ {
+ cannotVectorize();
+
+ final DataSource unnestDataSource = UnnestDataSource.create(
+ new TableDataSource(QueryRunnerTestHelper.DATA_SOURCE),
+ new ExpressionVirtualColumn(
+ QueryRunnerTestHelper.PLACEMENTISH_DIMENSION_UNNEST,
+ "\"" + QueryRunnerTestHelper.PLACEMENTISH_DIMENSION + "\"",
+ null,
+ ExprMacroTable.nil()
+ ),
+ null
+ );
+
+ GroupByQuery query = makeQueryBuilder()
+ .setDataSource(unnestDataSource)
+ .setQuerySegmentSpec(QueryRunnerTestHelper.FIRST_TO_THIRD)
+ .setDimensions(
+ new
DefaultDimensionSpec(QueryRunnerTestHelper.PLACEMENTISH_DIMENSION_UNNEST,
"alias0")
+ )
+ .setDimFilter(
+ new
EqualityFilter(QueryRunnerTestHelper.PLACEMENTISH_DIMENSION_UNNEST,
ColumnType.STRING, "a", null)
+ )
+ .setAggregatorSpecs(QueryRunnerTestHelper.ROWS_COUNT)
+ .setGranularity(QueryRunnerTestHelper.ALL_GRAN)
+ .addOrderByColumn("alias0", OrderByColumnSpec.Direction.ASCENDING)
+ .build();
+
+ // Total rows should add up to 26 * 2 = 52
Review Comment:
nit. this comment is not relevant here
##########
processing/src/test/java/org/apache/druid/query/groupby/UnnestGroupByQueryRunnerTest.java:
##########
@@ -704,6 +706,229 @@ private Iterable<ResultRow> runQuery(final GroupByQuery
query, final Incremental
return GroupByQueryRunnerTestHelper.runQuery(factory, queryRunner, query);
}
+ @Test
+ public void testGroupByOnUnnestedFilterMatch()
+ {
+ cannotVectorize();
+
+ final DataSource unnestDataSource = UnnestDataSource.create(
+ new TableDataSource(QueryRunnerTestHelper.DATA_SOURCE),
+ new ExpressionVirtualColumn(
+ QueryRunnerTestHelper.PLACEMENTISH_DIMENSION_UNNEST,
+ "\"" + QueryRunnerTestHelper.PLACEMENTISH_DIMENSION + "\"",
+ null,
+ ExprMacroTable.nil()
+ ),
+ null
+ );
+
+ GroupByQuery query = makeQueryBuilder()
+ .setDataSource(unnestDataSource)
+ .setQuerySegmentSpec(QueryRunnerTestHelper.FIRST_TO_THIRD)
+ .setDimensions(
+ new
DefaultDimensionSpec(QueryRunnerTestHelper.PLACEMENTISH_DIMENSION_UNNEST,
"alias0")
+ )
+ .setDimFilter(
+ new
EqualityFilter(QueryRunnerTestHelper.PLACEMENTISH_DIMENSION_UNNEST,
ColumnType.STRING, "a", null)
+ )
+ .setAggregatorSpecs(QueryRunnerTestHelper.ROWS_COUNT)
+ .setGranularity(QueryRunnerTestHelper.ALL_GRAN)
+ .addOrderByColumn("alias0", OrderByColumnSpec.Direction.ASCENDING)
+ .build();
+
+ // Total rows should add up to 26 * 2 = 52
+ // 26 rows and each has 2 entries in the column to be unnested
+ List<ResultRow> expectedResults = Collections.singletonList(
+ makeRow(
+ query,
+ "2011-04-01",
+ "alias0", "a",
+ "rows", 2L
+ )
+ );
+
+ Iterable<ResultRow> results = runQuery(query,
TestIndex.getIncrementalTestIndex());
+ TestHelper.assertExpectedObjects(expectedResults, results,
"groupBy-on-unnested-virtual-column");
+ }
+
+ @Test
+ public void testGroupByOnUnnestedNotFilterMatch()
+ {
+ cannotVectorize();
+
+ final DataSource unnestDataSource = UnnestDataSource.create(
+ new TableDataSource(QueryRunnerTestHelper.DATA_SOURCE),
+ new ExpressionVirtualColumn(
+ QueryRunnerTestHelper.PLACEMENTISH_DIMENSION_UNNEST,
+ "\"" + QueryRunnerTestHelper.PLACEMENTISH_DIMENSION + "\"",
+ null,
+ ExprMacroTable.nil()
+ ),
+ null
+ );
+
+ GroupByQuery query = makeQueryBuilder()
+ .setDataSource(unnestDataSource)
+ .setQuerySegmentSpec(QueryRunnerTestHelper.FIRST_TO_THIRD)
+ .setDimensions(
+ new
DefaultDimensionSpec(QueryRunnerTestHelper.PLACEMENTISH_DIMENSION_UNNEST,
"alias0")
+ )
+ .setDimFilter(
+ NotDimFilter.of(new
EqualityFilter(QueryRunnerTestHelper.PLACEMENTISH_DIMENSION_UNNEST,
ColumnType.STRING, "a", null))
+ )
+ .setAggregatorSpecs(QueryRunnerTestHelper.ROWS_COUNT)
+ .setGranularity(QueryRunnerTestHelper.ALL_GRAN)
+ .addOrderByColumn("alias0", OrderByColumnSpec.Direction.ASCENDING)
+ .build();
+
+ List<ResultRow> expectedResults = Arrays.asList(
+ makeRow(
+ query,
+ "2011-04-01",
+ "alias0", "b",
+ "rows", 2L
+ ),
+ makeRow(
+ query,
+ "2011-04-01",
+ "alias0", "e",
+ "rows", 2L
+ ),
+ makeRow(
+ query,
+ "2011-04-01",
+ "alias0", "h",
+ "rows", 2L
+ ),
+ makeRow(
+ query,
+ "2011-04-01",
+ "alias0", "m",
+ "rows", 6L
+ ),
+ makeRow(
+ query,
+ "2011-04-01",
+ "alias0", "n",
+ "rows", 2L
+ ),
+ makeRow(
+ query,
+ "2011-04-01",
+ "alias0", "p",
+ "rows", 6L
+ ),
+ makeRow(
+ query,
+ "2011-04-01",
+ "alias0", "preferred",
+ "rows", 26L
+ ),
+ makeRow(
+ query,
+ "2011-04-01",
+ "alias0", "t",
+ "rows", 4L
+ )
+ );
+
+ Iterable<ResultRow> results = runQuery(query,
TestIndex.getIncrementalTestIndex());
+ TestHelper.assertExpectedObjects(expectedResults, results,
"groupBy-on-unnested-virtual-column");
+ }
+
+ @Test
+ public void testGroupByOnUnnestedNotFilterMatchNonexistentValue()
+ {
+ cannotVectorize();
+
+ final DataSource unnestDataSource = UnnestDataSource.create(
+ new TableDataSource(QueryRunnerTestHelper.DATA_SOURCE),
+ new ExpressionVirtualColumn(
+ QueryRunnerTestHelper.PLACEMENTISH_DIMENSION_UNNEST,
+ "\"" + QueryRunnerTestHelper.PLACEMENTISH_DIMENSION + "\"",
+ null,
+ ExprMacroTable.nil()
+ ),
+ null
+ );
+
+ GroupByQuery query = makeQueryBuilder()
+ .setDataSource(unnestDataSource)
+ .setQuerySegmentSpec(QueryRunnerTestHelper.FIRST_TO_THIRD)
+ .setDimensions(
+ new
DefaultDimensionSpec(QueryRunnerTestHelper.PLACEMENTISH_DIMENSION_UNNEST,
"alias0")
+ )
+ .setDimFilter(
+ NotDimFilter.of(new
EqualityFilter(QueryRunnerTestHelper.PLACEMENTISH_DIMENSION_UNNEST,
ColumnType.STRING, "noexist", null))
+ )
+ .setAggregatorSpecs(QueryRunnerTestHelper.ROWS_COUNT)
+ .setGranularity(QueryRunnerTestHelper.ALL_GRAN)
+ .addOrderByColumn("alias0", OrderByColumnSpec.Direction.ASCENDING)
+ .build();
+
+ // Total rows should add up to 26 * 2 = 52
Review Comment:
nit. there are 52 values as filter is on non existent value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
