xvrl commented on code in PR #15106:
URL: https://github.com/apache/druid/pull/15106#discussion_r1370462186
##########
.github/workflows/static-checks.yml:
##########
@@ -51,12 +51,33 @@ jobs:
with:
distribution: 'zulu'
java-version: ${{ matrix.java }}
- cache: 'maven'
+
+ - name: restore maven dependencies
+ # restore maven dependencies only. 'depsonly' keys are safe to restore
+ # since they don't contain any artifacts created by mvn install
+ - uses: actions/cache/restore@v3
+ with:
+ key: maven-${{ runner.os }}-depsonly-${{ hashFiles('**/pom.xml') }}
+ path: ~/.m2/repository
+ restore-keys: |
+ maven-${{ runner.os }}-depsonly-
Review Comment:
I'm following the approach suggested in
https://github.com/actions/cache/blob/main/examples.md#java---maven.
Even if this includes older artifacts I believe it would still save us time
compared to downloading all artifacts again on every change to them pom. This
is no different than what happens when developing locally. I rarely have to
clean my local .m2 cache, and it does not grow that fast.
GitHub also limits the size of cached artifacts, so I expect the size to
stay bounded. If this becomes a problem we can revisit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
