kgyrtkirk commented on code in PR #15106:
URL: https://github.com/apache/druid/pull/15106#discussion_r1370789562
##########
.github/workflows/static-checks.yml:
##########
@@ -51,12 +51,33 @@ jobs:
with:
distribution: 'zulu'
java-version: ${{ matrix.java }}
- cache: 'maven'
+
+ - name: restore maven dependencies
+ # restore maven dependencies only. 'depsonly' keys are safe to restore
+ # since they don't contain any artifacts created by mvn install
+ - uses: actions/cache/restore@v3
+ with:
+ key: maven-${{ runner.os }}-depsonly-${{ hashFiles('**/pom.xml') }}
+ path: ~/.m2/repository
+ restore-keys: |
+ maven-${{ runner.os }}-depsonly-
+
+ - name: compile and cache maven dependencies
+ # run maven compile step to cache all shared maven dependencies
+ # maven install will be run in a subsequent step to avoid polluting
the global maven cache
Review Comment:
I believe we are developing the project ...and it should only produce
`org.apache.druid` artifacts - if it doesn't we should fix that...
but all of them seem to be under `.m2/repository/org/apache/druid` - do you
know about any which is not installed there?
I don't feel that using a crafted maven command to try to warm up the cache
would be a better approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
