janjwerner-confluent commented on code in PR #16009:
URL: https://github.com/apache/druid/pull/16009#discussion_r1507971811
##########
processing/pom.xml:
##########
@@ -81,6 +81,11 @@
<groupId>org.apache.commons</groupId>
<artifactId>commons-compress</artifactId>
</dependency>
+ <dependency>
+ <groupId>commons-codec</groupId>
+ <artifactId>commons-codec</artifactId>
+ <scope>runtime</scope>
Review Comment:
it's added to processing as this is where commons-compress is used.
The dependency is listed as optional for commons-compress
(https://mvnrepository.com/artifact/org.apache.commons/commons-compress/1.26.0)
and is not needed compile time. The dependency is needed runtime (as
illustrated by failing tests in https://github.com/apache/druid/pull/15932). If
we add it in the compile scope we will need to add the suppression of
dependency analyze tool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
