xvrl commented on code in PR #16009:
URL: https://github.com/apache/druid/pull/16009#discussion_r1508067842
##########
processing/pom.xml:
##########
@@ -81,6 +81,11 @@
<groupId>org.apache.commons</groupId>
<artifactId>commons-compress</artifactId>
</dependency>
+ <dependency>
+ <groupId>commons-codec</groupId>
+ <artifactId>commons-codec</artifactId>
+ <scope>runtime</scope>
Review Comment:
I see, can we add a comment to explain the reason for making it runtime?
Let's also update the PR description to mention that 1.26 added this
optional dependency and that it is required in our case to make tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
