clintropolis opened a new pull request, #16533:
URL: https://github.com/apache/druid/pull/16533
### Description
_todo: detailed description_
changes:
* Added `CursorBuildSpec` which captures all of the 'interesting' stuff that
goes into producing a cursor as a replacement for the method arguments of
`CursorFactory.canVectorize`, `CursorFactory.makeCursors`, and
`CursorFactory.makeVectorCursors`
* added new interfaces `CursorMaker` and new method `asCursorMaker` to
`CursorFactory`, which takes a `CursorBuildSpec` as an argument and replaces
`CursorFactory.canVectorize`, `CursorFactory.makeCursors`, and
`CursorFactory.makeVectorCursors`
* Deprecated `CursorFactory.canVectorize`, `CursorFactory.makeCursors`, and
`CursorFactory.makeVectorCursors`
* updated all `CursorFactory` implementations to implement `asCursorMaker`
* updated all query engines to use `asCursorMaker`
#### Release note
_todo_
<hr>
##### Key changed/added classes in this PR
* `CursorFactory`
* `CursorMaker`
* `CursorBuildSpec`
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
