clintropolis commented on code in PR #16533: URL: https://github.com/apache/druid/pull/16533#discussion_r1627196668
########## processing/src/main/java/org/apache/druid/segment/CursorFactory.java: ########## @@ -35,12 +38,55 @@ */ public interface CursorFactory { + default CursorMaker asCursorMaker(CursorBuildSpec spec) + { + + return new CursorMaker() + { + @Override + public boolean canVectorize() + { + return CursorFactory.this.canVectorize(spec.getFilter(), spec.getVirtualColumns(), spec.isDescending()); Review Comment: this is intended so that existing `CursorFactory`/`StorageAdapter` implementations can keep working with query engines without implementing `asCursorMaker` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org