kfaraz commented on code in PR #16481:
URL: https://github.com/apache/druid/pull/16481#discussion_r1628218203
##########
extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/output/RetryableS3OutputStream.java:
##########
@@ -269,52 +213,74 @@ public void close() throws IOException
// Closeables are closed in LIFO order
closer.register(() -> {
// This should be emitted as a metric
+ long totalChunkSize = (currentChunk.id - 1) * chunkSize +
currentChunk.length();
Review Comment:
It's fine for now. We can worry about it when we really need to do something
with the chunk. For now, let's just stick with the list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
