Akshat-Jain commented on code in PR #16481:
URL: https://github.com/apache/druid/pull/16481#discussion_r1628749775
##########
extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/output/RetryableS3OutputStream.java:
##########
@@ -103,27 +94,28 @@ public class RetryableS3OutputStream extends OutputStream
private boolean error;
private boolean closed;
- public RetryableS3OutputStream(
- S3OutputConfig config,
- ServerSideEncryptingAmazonS3 s3,
- String s3Key
- ) throws IOException
- {
+ /**
+ * Helper class for calculating maximum number of simultaneous chunks
allowed on local disk.
+ */
+ private final S3UploadManager uploadManager;
- this(config, s3, s3Key, true);
- }
+ /**
+ * A list of futures to allow us to wait for completion of all uploadPart()
calls
+ * before hitting {@link
ServerSideEncryptingAmazonS3#completeMultipartUpload(CompleteMultipartUploadRequest)}.
+ */
+ private final List<Future<UploadPartResult>> futures = new ArrayList<>();
Review Comment:
Marking this resolved as per the discussion at
https://github.com/apache/druid/pull/16481#discussion_r1628218203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
